Fix app minimising and general console errors #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 16, 2023 13:36
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
Morsey187
commented
Nov 17, 2023
mixxorz
requested changes
Nov 17, 2023
|
@mixxorz Pushed some updates for linting and the type import. |
mixxorz
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://torchbox.monday.com/boards/1143413211/pulses/1296858262
This PR fixes an issue with the app closing, a bug related to the webview being nested inside a scrollview. More specifically when the markdown component (which uses webview) renders inside the DeviceInfoScreen (uses scrollview).
As well as resolving a console error by bumping a package, some circular dependency warnings and a few type errors.