Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bluetooth connection checks #133

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix bluetooth connection checks #133

merged 2 commits into from
Nov 22, 2023

Conversation

Morsey187
Copy link
Collaborator

Replaces use of addHeadphonesListener with use of DeviceInfo.isHeadphonesConnected "Re-checks connection" button.
Includes updates to AlertButton to better handle closing alerts.

mixxorz
mixxorz approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@mixxorz mixxorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although with some reservation that DeviceInfo.isHeadphonesConnectedSync() is actually using deprecated Android APIs.

@Morsey187 Morsey187 merged commit a492014 into develop Nov 22, 2023
1 of 2 checks passed
@Morsey187 Morsey187 deleted the fix/headphone-connection branch November 22, 2023 09:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixxorz mixxorz mixxorz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morsey187 @mixxorz