Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flarum scheduler guide to docs #459

Merged
merged 2 commits into from
May 24, 2023
Merged

Add Flarum scheduler guide to docs #459

merged 2 commits into from
May 24, 2023

Conversation

iamdarkle
Copy link
Member

This PR includes the Flarum scheduler guide (https://discuss.flarum.org/d/24118-setup-the-flarum-scheduler-using-cron) to the docs. I have included the guide under the Management section, I think it fits best (?).

I've taken the liberty to adjust a bit the content of Ian's original tutorial a bit, taking into account that this will be in the docs... Feel free to correct or change what you think is appropriate.

Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use words like "easy" and "simple" because it might not be for some. Other than that, just some minor changes.

docs/scheduler.md Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
docs/scheduler.md Outdated Show resolved Hide resolved
Co-authored-by: David Wheatley <david@davwheat.dev>
@iamdarkle
Copy link
Member Author

Much better now, thanks for the review :)

@iamdarkle iamdarkle requested a review from davwheat May 24, 2023 20:13
@davwheat davwheat merged commit 8bc661d into flarum:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants