Skip to content

Commit

Permalink
Fix a missed getRouteData()
Browse files Browse the repository at this point in the history
  • Loading branch information
SychO9 committed Apr 7, 2021
1 parent 9839370 commit 1cca4e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Forum/ForumServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ protected function setDefaultRoute(RouteCollection $routes)
$defaultRoute = $this->container->make('flarum.settings')->get('default_route');

if (isset($routes->getRouteData()[0]['GET'][$defaultRoute]['handler'])) {
$toDefaultController = $routes->getRoutes()['GET'][$defaultRoute]['handler'];
$toDefaultController = $routes->getRouteData()[0]['GET'][$defaultRoute]['handler'];
} else {
$toDefaultController = $factory->toForum(Content\Index::class);
}
Expand Down

2 comments on commit 1cca4e8

@askvortsov1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this pass the automated tests...

@SychO9
Copy link
Member Author

@SychO9 SychO9 commented on 1cca4e8 Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what changed but styleci fixes used to trigger the backend tests, but not anymore, which might turn out problematic for PRs.

StyleCi commit triggering tests here: github.com//pull/2596
But not here: github.com//pull/2754

Please sign in to comment.