update a user's comment count if deleting a discussion (#2472)

flarum · Nov 29, 2020 · 387b4fd · 387b4fd
1 parent 66482c2
commit 387b4fd
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/User/UserMetadataUpdater.php b/src/User/UserMetadataUpdater.php
@@ -14,7 +14,6 @@
 use Flarum\Discussion\Event\Started;
 use Flarum\Post\Event\Deleted as PostDeleted;
 use Flarum\Post\Event\Posted;
-use Flarum\Post\Post;
 use Illuminate\Contracts\Events\Dispatcher;
 
 class UserMetadataUpdater
@@ -35,15 +34,15 @@ public function subscribe(Dispatcher $events)
      */
     public function whenPostWasPosted(Posted $event)
     {
-        $this->updateCommentsCount($event->post);
+        $this->updateCommentsCount($event->post->user);
     }
 
     /**
      * @param \Flarum\Post\Event\Deleted $event
      */
     public function whenPostWasDeleted(PostDeleted $event)
     {
-        $this->updateCommentsCount($event->post);
+        $this->updateCommentsCount($event->post->user);
     }
 
     /**
@@ -60,12 +59,14 @@ public function whenDiscussionWasStarted(Started $event)
     public function whenDiscussionWasDeleted(DiscussionDeleted $event)
     {
         $this->updateDiscussionsCount($event->discussion);
+        $this->updateCommentsCount($event->discussion->user);
     }
 
-    private function updateCommentsCount(Post $post)
+    /**
+     * @param \Flarum\User\User $user
+     */
+    private function updateCommentsCount(User $user)
     {
-        $user = $post->user;
-
         if ($user && $user->exists) {
             $user->refreshCommentCount()->save();
         }