You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
eee no I think this is an important line :3 it's needed to set the type column to the appropriate value, as defined in subclasses of Post (CommentPost, DiscussionRenamedPost)
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? Then why do all posts (in the posts seeder) set the type column manually? Also, the static $type property does not seem to exists, see #67.
The reason will be displayed to describe this comment to others. Learn more.
Ah, it only exists for subtypes, I think. So, I think we should only overwrite $post->type if it doesn't already exist (to fix the seeders) or update the seeders...
The reason will be displayed to describe this comment to others. Learn more.
Yeah the seeder is out of date. It's a static property I added in f2056c4 to make things a bit cleaner. Forgot to add it to the base class. Post should be an abstract class, and the seeder should use CommentPost and DiscussionRenamedPost.
df8a035
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eee no I think this is an important line :3 it's needed to set the
type
column to the appropriate value, as defined in subclasses of Post (CommentPost, DiscussionRenamedPost)df8a035
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? Then why do all posts (in the posts seeder) set the type column manually? Also, the static
$type
property does not seem to exists, see #67.df8a035
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it only exists for subtypes, I think. So, I think we should only overwrite
$post->type
if it doesn't already exist (to fix the seeders) or update the seeders...df8a035
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the seeder is out of date. It's a static property I added in f2056c4 to make things a bit cleaner. Forgot to add it to the base class. Post should be an abstract class, and the seeder should use CommentPost and DiscussionRenamedPost.
df8a035
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll fix that.
df8a035
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks