-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant? #16
Comments
Probably a good idea. I haven't been developing on vagrant/Homestead so far just because of slowness (local requests taking ~1 second), but maybe that's just the way I had it set up? |
I haven't had any issues with Vagrant. Loading applications in development is a bit slower, especially if you're running profiling tools. I typically use https://github.com/fideloper/vaprobash instead of homestead since I like to have projects in separate and isolated environments. |
+1 for Vagrant. I have come to realize (the hard way) on the importance of a consistent dev environment. |
If no one else is hacking on this I'll PR a vagrantfile and setup scripts tonight Sent from my iPhone
|
That'd be great, thanks! |
PR #21 |
You may wish to disregard that PR, I'm going to suggest creating a skeleton app repo for testing the application and consuming the flarum/core repo within the workbench of that |
Skeleton app: https://github.com/mikedugan/flarum-app |
@mikedugan would you mind filling out the Readme for your flarum-app repo? I am on mobile now and unable to check out code.. but I am confused by your statement "suggest creating a skeleton app repo for testing the application and consuming the flarum/core repo within the workbench of that" |
I’ll be pushing this up in an hour-ish, feel free to have a look whenever. The general idea is that there should be a skeleton application that bootstraps a ready-to-hack dev version of the application inside a vagrant box. In more words or less, it’s just the installation instructions in this repo applied in the form of some bash scripts. -- On December 27, 2014 at 7:55:02 AM, Russell Dempsey (notifications@github.com) wrote: @mikedugan would you mind filling out the Readme for your flarum-app repo? I am on mobile now and unable to check out code.. but I am confused by your statement "suggest creating a skeleton app repo for testing the application and consuming the flarum/core repo within the workbench of that" — |
Running a couple more tests and this will be pushed up at mikedugan/flarum-app |
Ok, looks like everything is working from my end. The skeleton app is basically the installation instructions in the flarum/core README converted to a vagrantfile and bash script. When you run vagrant up, it will do the following:
It also registers a command line alias |
can confirm, vagrantfile with skeleton app is working as intended. 👍 |
@qrokodial thanks, glad to hear you got it working 🍺 |
Great work Mike, thanks for setting this up! I will merge + fork the skeleton app repo tomorrow. |
Looking great @mikedugan. Given that Nginx is faster, I'm just wondering if Apache would be a better option instead of Nginx. The only rationale being that Apache seems like the standard installation on most servers and its probably more easier to approach for new programmers. Thoughts? |
OK, forked into flarum/flarum and updated the flarum/core readme's installation instructions. I haven't actually been able to test yet (don't have access to good Internet right now so can't download the vagrant image) so please reopen this / send a PR if anything is wrong! |
@ghosh I think right now developing on Nginx is fine. Once Flarum is in a more usable state we'll be working on an versatile installation method without vagrant. |
ok 👍 That sounds good. |
Just adding another .02 - the point behind using the vagrant box is so that whoever happens to be developing on flarum won't have to set up a webserver etc. In case it's not clear to anyone / anyone isn't familiar with vagrant, vagrant is only a development environment and isn't meant for use in production. Sent from my iPhone
|
Another useful point about Vagrant is that it lets you accurately mimic your production environment while you develop. Thus preventing any nasty surprises which you may get after pushing to production. |
@ghosh that's a bit less relevant in this scenario since it's intended for public consumption...there's no realistic way we could anticipate the ∞ different production environments people might try to deploy to |
@mikedugan Thats exactly why I was suggesting using the least common denominator - which is a basic installation of a LAMP stack. Anyway, my previous comment was not an argument. I was just adding to your points about Vagrant for people who may not have used it. |
Use pipe instead of redirect for release.zip
_1 Upvote_ Have you considered dropping in a vagrant box to ensure consistent development environments when developers start forking and working with the codebase?
The text was updated successfully, but these errors were encountered: