Viewing topic doesn't jump to last unread post

[tomdav999]

For exampe, I am viewing the "word association game" thread with lots of posts. The first unread post is 91. When I click on the topic it takes me to post 91. I then scroll down to view post 99. I then view another topic and come back to the "word association game" thread. It returns me to post 91. Shouldn't it take me to post 100? Also, I noticed that on my non-mobile device when clicking on the same topic in the left pane it behaves correctly each time I click on the topic (essentially paging down to the next unread post every time I click on the topic in the left pane) but as soon as I visit on another topic in the left pane and then come back it reverts to post 91. Oddly enough on my mobile device (with no pane view) if I hit my browser's back button to view the list of topics and click on the topic again it takes me to post 92 (it doesn't page down like it does in pane view). If I use flarum's back button to view the list of topics and click on the topic again it takes me to post 91.

[franzliedke]

When you say you "come back" to the thread, are you referring to using the back button? Or visiting it again?

[franzliedke]

I'd actually think that the back-button behavior in the desktop browser is okay.

What I'd think should change: clicking on the side panel to advance to the next unread post should not use replaceState (thus, the back button should have the desired effect there).

@tobscure Do you agree?

[tobyzerner]

This bug report confuses me... 🤔

@franzliedke I think I agree with that though.

[tarunmarkose]

I've faced this too. I think what OP means is that Flarum doesn't always
remember your last read post correctly and takes you to a part of the
thread that you've already read before. Then you gotta keep scrolling
down until you reach the correct point where you last left off.

On Friday 29 July 2016, Toby Zerner notifications@github.com wrote:

This bug report confuses me... 🤔

@franzliedke https://github.com/franzliedke I think I agree with that
though.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#285 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHCrLJPjEsWDxWF5o83UBSS92roifttNks5qaegfgaJpZM4Fz0_O
.

-Tarun

[tomdav999]

@tobscure, when I posted the bug report almost a year ago it was working as I described in the OP. I just tested again and I can't replicate some of the strange things I was seeing back then so I can appreciate that it might be confusing now to the extent this has been fixed. @franzliedke by "come back" I meant hitting the browser's back button to return to the list of topics and then click on the topic again. It really shouldn't matter how you got to the list of topics (whether it be via the browser's back button, flarum's back button, flarum search, flarum side pane, etc.) when you click on a topic it should always dynamically take you to the first unread post. That's how it seems to work now, but @tarunmarkose may have other data points. Honestly I haven't been using flarum much lately to say.

[tomdav999]

BTW, just realized I made a typo in the title. I meant to say it wasn't jumping to first unread post (or alternatively last read post).

[tomdav999]

After more testing with different devices, things are still somewhat buggy. If I go to desktop and click on the word association thread there are roughly 4.5 viewable posts per page and it correctly advances 4 posts every time I click on the thread. For example, xxxx of yyyy posts counter shows 1248, 1252, 1256, 1260 for xxxx. But on my mobile device xxxx is stuck on 1248. If I hit my mobile browser's back button (or flarum's back button) then click on the thread again, xxxx indicates 1248 (not where desktop left off at 1260). There are roughly 2.5 posts on the screen so it should be advancing 2 each time (regardless of whether it knows desktop left off at 1260). This is why in the OP I believed mobile had different behavior, but it's really that flarum isn't calculating the correct number of viewable posts properly on my mobile device (it thinks less than 1 post is viewable so it never advances). If I wait ~20 seconds xxxx goes to 1260 (where desktop left off but remains stuck there). I tested another browser on my mobile phone (chrome) and it only advances 1 each time I click on the thread (1260, 1261, 1262, 1263, etc.) even though there are 2.5 posts on the screen.

[Eldenroot]

Really annoying bug :(

[matteocontrini]

Is this actually an issue? I've never experienced this in the 3 ½ years I've been using Flarum 🤔

[askvortsov1]

I don't think I have either. I'll close this, we can reopen if it comes up again. Given how many changes have been made to PostStream, it's probably been fixed somewhere along the line.