Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PermissionGrid doesn't work #3169

Closed
SychO9 opened this issue Nov 19, 2021 · 2 comments · Fixed by #3197
Closed

PermissionGrid doesn't work #3169

SychO9 opened this issue Nov 19, 2021 · 2 comments · Fixed by #3197
Assignees
@askvortsov1
Labels
type/regression

Comments

@SychO9
Copy link
Member

SychO9 commented Nov 19, 2021

Bug Report

Current Behavior
Accessing the permissions page produces the following error and the loading indicator remains.

TypeError: Vnodes must either always have keys or never have keys!
    at Function.e.normalizeChildren (vnode.js:21)
    at Function.e.normalize (vnode.js:7)
    at Function.e.normalizeChildren (vnode.js:25)
    at t.exports (hyperscript.js:93)
    at s (index.js:7)
    at n (patchMithril.js:7)
    at PermissionGrid.tsx:75
    at Array.map (<anonymous>)
    at PermissionGrid.tsx:74
    at Array.map (<anonymous>)
a @ mount-redraw.js:15

Environment

  • Flarum version: 1.2.0-dev
@SychO9 SychO9 added this to the 1.2 milestone Nov 19, 2021
@askvortsov1
Copy link
Member

I am unable to replicate this in the latest dev-master, is this still an issue?

@SychO9
Copy link
Member Author

SychO9 commented Nov 25, 2021

I can still reproduce, you need to restrict by tag, checkout nightly.

askvortsov1 added a commit that referenced this issue Nov 25, 2021
@askvortsov1
PermissionGrid fixes
d2a755c 
Fixes #3169 (comment)

- Restore wrapping `scope.render` results in a table cell tag. This was accidentially introduced in 924815b, and caused the issue linked above
- Rename the `SettingDropdown` attr `key` to `setting` in order to avoid naming clashes with Mithril vnode keys. `key` still works, but is deprecated.
askvortsov1 added a commit that referenced this issue Dec 13, 2021
@askvortsov1
PermissionGrid fixes
23a70af 
Fixes #3169 (comment)

- Restore wrapping `scope.render` results in a table cell tag. This was accidentially introduced in 924815b, and caused the issue linked above
- Rename the `SettingDropdown` attr `key` to `setting` in order to avoid naming clashes with Mithril vnode keys. `key` still works, but is deprecated.
@askvortsov1 askvortsov1 mentioned this issue Dec 13, 2021
Merged
askvortsov1 added a commit that referenced this issue Dec 13, 2021
@askvortsov1
PermissionGrid fixes
46893a9 
Fixes #3169 (comment)

- Restore wrapping `scope.render` results in a table cell tag. This was accidentially introduced in 924815b, and caused the issue linked above
- Rename the `SettingDropdown` attr `key` to `setting` in order to avoid naming clashes with Mithril vnode keys. `key` still works, but is deprecated.
@SychO9 SychO9 removed this from the 1.2 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askvortsov1 askvortsov1

Labels
type/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Permission grid fixes flarum/framework
2 participants
@SychO9 @askvortsov1