Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion page scrolling issue on iOS #3703

Closed
GreXXL opened this issue Dec 2, 2022 · 4 comments · Fixed by #3821
Closed

Discussion page scrolling issue on iOS #3703

GreXXL opened this issue Dec 2, 2022 · 4 comments · Fixed by #3821
Labels
Milestone

Comments

@GreXXL
Copy link
Member

GreXXL commented Dec 2, 2022

Current Behavior

Currently on a discussions page it’s possible to scroll horizontally which is influencing the browsing experience.

https://files.fm/f/43rjsdfks

As stated in a discussion this might be a new big since at least 1.5.0 (https://discuss.flarum.org/d/32014-how-to-downgrade-from-162-to-14)

Steps to Reproduce

Open a discussion page on any Flarum Forum

Expected Behavior

No horizontal scroll possible like it also is the case in „All discussions“ page.

Screenshots

No response

Environment

  • Flarum version: 1.6.1
  • Website URL: https:/discussion.Flarum.org
  • Browser: Latest iOS Safari

Output of php flarum info

Output of "php flarum info", run this in terminal in your Flarum directory.

Possible Solution

No response

Additional Context

No response

@GreXXL GreXXL added the type/bug label Dec 2, 2022
@luceos luceos added this to the 1.7 milestone Dec 22, 2022
@SychO9 SychO9 modified the milestones: 1.7, 1.8 Mar 6, 2023
@ekumanov
Copy link

ekumanov commented Apr 21, 2023

Here's a CSS that I found fixes the issue:

html, body{
  overflow-x: hidden;
}

However I'm not sure it's a proper fix. I'm not a web developer and that CSS might negatively impact something else. As a matter of fact, the issue appeared after 1.5 and it affects only the discussion view (when you have open a discussion and scrolling it) and not the main view with the list of all discussions. So, apparently the root cause is something else and it's a regression and I'm not sure a global CSS like the one above should be the solution.

@matteocontrini
Copy link
Contributor

I remember that the overflow-x: hidden was there on .App in the past but was removed in #3540, released in 1.5.0. I think that's the reason why the problem started to appear in 1.5.0.

However it seems that the property interfered with the sticky sidebar, so it might be worth checking if it's still a problem @SychO9

@SychO9
Copy link
Member

SychO9 commented May 7, 2023

Thanks @matteocontrini, I couldn't find why the change had been made. It does interfere with sticky positioning. So reverting that won't work then.

@SychO9 SychO9 closed this as completed May 7, 2023
@SychO9 SychO9 reopened this May 7, 2023
@ekumanov
Copy link

ekumanov commented May 7, 2023

I also discovered that the CSS in question affects the sticky sidebar. However since there's no sidebar on mobile, I enable the CSS only for mobile:

@media @phone {
  html, body{
    overflow-x: hidden;
  }
}

This seems to be working fine without affecting the sidebar on desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants