-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use position: sticky
for discussion side nav
#3540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychO9
requested changes
Jul 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
SychO9
approved these changes
Jul 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
SychO9
added a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
8 tasks
SychO9
added a commit
that referenced
this pull request
Sep 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3541
Changes proposed in this pull request:
Swaps
position: fixed
forposition: sticky
for the Discussion sidebar. This helps to increase the amount of screen real estate for extension to add controls to the sidebar, when a large discussion hero is used.Reviewers should focus on:
Removal of the
overflow-x: hidden
is needed for sticky to work correctly. This shouldn't pose any issues for us, but bad extensions could cause x overflow to occur now.Screenshot
MIQPCApG.mp4
GxNZkrpE.mp4
Necessity
Confirmed
composer test
).