Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use position: sticky for discussion side nav #3540

Merged
merged 4 commits into from
Jul 17, 2022
Merged

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jul 16, 2022

Fixes #3541

Changes proposed in this pull request:

Swaps position: fixed for position: sticky for the Discussion sidebar. This helps to increase the amount of screen real estate for extension to add controls to the sidebar, when a large discussion hero is used.

Reviewers should focus on:

Removal of the overflow-x: hidden is needed for sticky to work correctly. This shouldn't pose any issues for us, but bad extensions could cause x overflow to occur now.

We could keep it, but set to visible when the selector is .App.App-discussion instead.

Screenshot

MIQPCApG.mp4
GxNZkrpE.mp4

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.5 milestone Jul 16, 2022
@davwheat davwheat requested a review from SychO9 July 16, 2022 21:53
@davwheat davwheat self-assigned this Jul 16, 2022
@davwheat davwheat marked this pull request as ready for review July 16, 2022 22:08
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

framework/core/less/common/App.less Outdated Show resolved Hide resolved
@davwheat davwheat requested a review from SychO9 July 17, 2022 09:25
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davwheat davwheat merged commit 29179e2 into main Jul 17, 2022
@davwheat davwheat deleted the dw/sticky-sidebar branch July 17, 2022 10:06
SychO9 added a commit that referenced this pull request Aug 26, 2022
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
SychO9 added a commit that referenced this pull request Sep 3, 2022
* chore: merge media queries
* chore: change discussion page skeleton to grid layout
* chore: use grid areas instead of order

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sticky position instead of fixed for the scrubber
2 participants