Updated names to match components in fontawsome #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa-* named components are not present, hence updated to matching names.
|
This will require changing the version requirement of |
|
@pixma Annim can you change the constraint in package.json as @datitisev correctly proposes? It looks fine otherwise 👍 Thank you so much for your first time contribution on Flarum! |
wzdiyb
pushed a commit
to wzdiyb/core
that referenced
this pull request
Feb 16, 2020
fa-* named components are not present, hence updated to matching names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa-* named components are not present, hence updated to matching names.
Changes proposed in this pull request:
In file common.less Changes are proposed.
fa-brands to brands as the components in the fontawsome folder are now with name as brands.
Confirmed
Required changes:
Update the common.less file with correct names to match components in font awesome.