WIP Frontend Framework Rewrite #1950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsevillamartin
changed the title
65 tasks
65 tasks
Compatible with existing language packs, exposes 'moment' variable to window that is the same as 'dayjs'
Required some custom code to mimic the functionality of the modal backdrop from Boostrap
Breaking spin.js update moved from JS animations to CSS keyframes, so the default keyframe was added to LoadingIndicator.less
This adds ~18kb to dist file, which isn't ideal. Open to lighter alternatives, wasn't able to find many.
dsevillamartin
force-pushed
the
ds/frontend-framework-rewrite
branch
from
249fd0b to
4c358de
Compare
dsevillamartin
added a commit
that referenced
this pull request
Apr 20, 2020
They got lost when I dropped the commits
65 tasks
|
#2255 is where it's at. ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mithril & TypeScript changes can be seen at #2126.
See #1821.