-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index page title, add mechanism to clear title from defaultRoute. #2047
Add index page title, add mechanism to clear title from defaultRoute. #2047
Conversation
6a46b46
to
045ee33
Compare
045ee33
to
d74dfe8
Compare
Because we now auto-format our JS code with Prettier, this branch now has conflicts with Please take the steps outlined in the forum to resolve the conflicts. |
ca8d5bb
to
7d6dcb0
Compare
I believe this PR only changes the behavior on the javascript side, the title on the PHP/preload side will still include the page title? This does not need to be the same PR, but changing one and not the other wouldn't make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@askvortsov1 what's the plan regarding to my comments above?
Also other comments:
- Should use triple ===
- I think the title count feature should also work on the homepage
cb88ede
to
0b486d2
Compare
Done, all good points. Thanks! Also, now that Document has access to request, perhaps we should just use the current url for canonical url (in a separate PR)? That's often what we do anyway... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! Just one question in the comments below.
Also, now that Document has access to request, perhaps we should just use the current url for canonical url (in a separate PR)? That's often what we do anyway...
Definitely something for another issue/PR. I am doubtful that's how we do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I definitely think it's cleaner that way, even though both options would do practically the same.
That way people reading the code don't need to dig into the documentation to find out what originalUri means.
Fixes #495
Changes proposed in this pull request:
Add index page title, add mechanism to clear title from defaultRoute.
Confirmed
composer test
).