Code

Extract PostStream state#2160

Code

Merged

askvortsov1 merged 65 commits intomasterflarum/framework:masterfrom as/frontend_rewrite_post_stream_state_try_4flarum/framework:as/frontend_rewrite_post_stream_state_try_4Copy head branch name to clipboardAug 8, 2020

+597-608

Commits

Commits on Jul 31, 2020

• Extract PostStream state

  

  askvortsov1

  authored and

  franzliedke

  committed
  7af8e35

  Copy full SHA for 7af8e35

• Remove event from PostState, pass handler in via props,

  

  askvortsov1

  authored and

  franzliedke

  committed
  cff9b32

  Copy full SHA for cff9b32

• Moved refresh method of discussionpage into init, as its not used externally (and using it would be bad practice), fixing up PostStream

  

  askvortsov1

  authored and

  franzliedke

  committed
  614bb0d

  Copy full SHA for 614bb0d

• Revert inlining method, rename the method instead

  franzliedke

  committed
  6bcecd6

  Copy full SHA for 6bcecd6

• Remove obsolete event handler

  Show description for 6c087da
  franzliedke

  committed
  6c087da

  Copy full SHA for 6c087da

• Encapsulate viewingEnd() in state

  Show description for 8a9e50d
  franzliedke

  committed
  8a9e50d

  Copy full SHA for 8a9e50d

• Don't call protected method outside of state

  Show description for 062dc8f
  franzliedke

  committed
  062dc8f

  Copy full SHA for 062dc8f

• Pass discussion as prop to stream components

  Show description for 2ec49db
  franzliedke

  committed
  2ec49db

  Copy full SHA for 2ec49db

• Large simplifications of PostStreamScrubber

  

  askvortsov1

  authored and

  franzliedke

  committed
  5427b35

  Copy full SHA for 5427b35

• Simplify paused logic

  

  askvortsov1

  authored and

  franzliedke

  committed
  9c63c54

  Copy full SHA for 9c63c54

• Add scrubber height change transition css, don't apply when dragging

  

  askvortsov1

  authored and

  franzliedke

  committed
  9a357f5

  Copy full SHA for 9a357f5

• Use scrollToIndex to contain scrollToLast

  

  askvortsov1

  authored and

  franzliedke

  committed
  51008bc

  Copy full SHA for 51008bc

• Fix goToLast

  

  askvortsov1

  authored and

  franzliedke

  committed
  c03fece

  Copy full SHA for c03fece

• Get rid of js-PostStream

  

  askvortsov1

  authored and

  franzliedke

  committed
  eb24e62

  Copy full SHA for eb24e62

• Get rid of post stream events. Initial load is still buggy

  

  askvortsov1

  authored and

  franzliedke

  committed
  74cb4f9

  Copy full SHA for 74cb4f9

• Slightly improve scrubber label accuracy on click

  

  askvortsov1

  authored and

  franzliedke

  committed
  193f3b0

  Copy full SHA for 193f3b0

• Code cleanup, added a bunch of debug console logging

  

  askvortsov1

  authored and

  franzliedke

  committed
  6e1d385

  Copy full SHA for 6e1d385

• Move scrollPromise log into scrollToItem

  

  askvortsov1

  authored and

  franzliedke

  committed
  5cdfeaf

  Copy full SHA for 5cdfeaf

• Separate updateScrubber into separate method from onscroll

  

  askvortsov1

  authored and

  franzliedke

  committed
  1360723

  Copy full SHA for 1360723

• Update scrubber after scrollToItem

  

  askvortsov1

  authored and

  franzliedke

  committed
  beab8ce

  Copy full SHA for beab8ce

• Add some more debugging flags

  

  askvortsov1

  authored and

  franzliedke

  committed
  c150c09

  Copy full SHA for c150c09

• Add more console logs

  

  askvortsov1

  authored and

  franzliedke

  committed
  b2917c8

  Copy full SHA for b2917c8

• Remove unnecessary redraw

  

  askvortsov1

  authored and

  franzliedke

  committed
  ba82969

  Copy full SHA for ba82969

• Add redraws after posts have been loaded from the API

  

  askvortsov1

  authored and

  franzliedke

  committed
  f8d1c7a

  Copy full SHA for f8d1c7a

• Cleanup

  

  askvortsov1

  authored and

  franzliedke

  committed
  e84960d

  Copy full SHA for e84960d

• Anchor scroll after loading posts

  

  askvortsov1

  authored and

  franzliedke

  committed
  514165c

  Copy full SHA for 514165c

• Remove unused anchorScroll import

  

  askvortsov1

  authored and

  franzliedke

  committed
  ac1eef7

  Copy full SHA for ac1eef7

• Add anchorScroll with redraw after loadPromise loads in scrollToItem

  

  askvortsov1

  authored and

  franzliedke

  committed
  9572863

  Copy full SHA for 9572863

• Incorporate math floor in sanitizeIndex, use that for scrubber index display.

  

  askvortsov1

  authored and

  franzliedke

  committed
  9db2f78

  Copy full SHA for 9db2f78

• Pass in a selector string to anchorScroll instead of a DOM element. Because the DOM element gets destroyed on redraw, it's offset height is interpreted as 0 which throws off our position in the str…

  Show description for 0c63be5
  

  askvortsov1

  authored and

  franzliedke

  committed
  0c63be5

  Copy full SHA for 0c63be5

• Ensure consistent index in scrubber, rework current post index calculation logic.

  

  askvortsov1

  authored and

  franzliedke

  committed
  aa15db6

  Copy full SHA for aa15db6

• Properly bind loadNext button to the state

  

  askvortsov1

  authored and

  franzliedke

  committed
  9f2540d

  Copy full SHA for 9f2540d

• Use same logic as in updateScrubber to calculate current post number

  

  askvortsov1

  authored and

  franzliedke

  committed
  4bce030

  Copy full SHA for 4bce030

• in goToNumber, only redraw when the response has been returned.

  

  askvortsov1

  authored and

  franzliedke

  committed
  479e5a8

  Copy full SHA for 479e5a8

• Handle scroll to end as a special case of scroll to index to ensure that we get completely to the bottom and flash the bottom element

  

  askvortsov1

  authored and

  franzliedke

  committed
  d3fb5ee

  Copy full SHA for d3fb5ee

• Don't use anchorScroll on goToNumber, instead scrolling directly to item

  

  askvortsov1

  authored and

  franzliedke

  committed
  73507f4

  Copy full SHA for 73507f4

• Fix missing method call

  

  askvortsov1

  authored and

  franzliedke

  committed
  c98c0b0

  Copy full SHA for c98c0b0

• Get rid of separate system for scrollToLast

  

  askvortsov1

  authored and

  franzliedke

  committed
  cc10eaa

  Copy full SHA for cc10eaa

• Fix jumping around on page reload

  

  askvortsov1

  authored and

  franzliedke

  committed
  2360745

  Copy full SHA for 2360745

• Try calculating index before redraw to avoid calling redraw immediately after scroll

  

  askvortsov1

  authored and

  franzliedke

  committed
  ef20649

  Copy full SHA for ef20649

• Fix date, index calculation on reload

  

  askvortsov1

  authored and

  franzliedke

  committed
  875a1f7

  Copy full SHA for 875a1f7

• Use date of the post in index

  

  askvortsov1

  authored and

  franzliedke

  committed
  d20650f

  Copy full SHA for d20650f

• Restore scrubber behavior

  

  askvortsov1

  authored and

  franzliedke

  committed
  cdcf648

  Copy full SHA for cdcf648

• move index calculation back out of show

  

  askvortsov1

  authored and

  franzliedke

  committed
  228c7b8

  Copy full SHA for 228c7b8

• When scrolling to first post, scroll all the way to top, simplify scrollToItem promise structure

  

  askvortsov1

  authored and

  franzliedke

  committed
  88e6be9

  Copy full SHA for 88e6be9

• Fix date not showing up properly

  

  askvortsov1

  authored and

  franzliedke

  committed
  5ef4de7

  Copy full SHA for 5ef4de7

• Minor cleanup of PostStreamState methods

  

  askvortsov1

  authored and

  franzliedke

  committed
  92b62e7

  Copy full SHA for 92b62e7

• A bit more cleanup, UI bugfixes

  

  askvortsov1

  authored and

  franzliedke

  committed
  af55a13

  Copy full SHA for af55a13

• Restore old scrubber index calculation system

  

  askvortsov1

  authored and

  franzliedke

  committed
  a850f4a

  Copy full SHA for a850f4a

• A bit more cleanup and bugfixes

  

  askvortsov1

  authored and

  franzliedke

  committed
  1d86620

  Copy full SHA for 1d86620

• A bit more cleanup

  

  askvortsov1

  authored and

  franzliedke

  committed
  bbd8136

  Copy full SHA for bbd8136

• De-propify visible

  

  askvortsov1

  authored and

  franzliedke

  committed
  f99f79e

  Copy full SHA for f99f79e

• Don't save index twice in post stream post-load

  

  askvortsov1

  authored and

  franzliedke

  committed
  8c362bf

  Copy full SHA for 8c362bf

• Revert formatting changes

  franzliedke

  committed
  1a2f952

  Copy full SHA for 1a2f952

• Fix docblock

  franzliedke

  committed
  aae6f24

  Copy full SHA for aae6f24

• Rename props

  franzliedke

  committed
  3ce9475

  Copy full SHA for 3ce9475

• Remove unused prop

  franzliedke

  committed
  09c722e

  Copy full SHA for 09c722e

• Fix docblocks

  franzliedke

  committed
  8b69b24

  Copy full SHA for 8b69b24

• Move method to previous position

  franzliedke

  committed
  57f5ad4

  Copy full SHA for 57f5ad4

• Encapsulate a bit more logic in the state

  franzliedke

  committed
  0138413

  Copy full SHA for 0138413

• Add default parameter value

  Show description for a044c64
  franzliedke

  committed
  a044c64

  Copy full SHA for a044c64

• Restore old implementation of goToLast()

  Show description for e455e6c
  franzliedke

  committed
  e455e6c

  Copy full SHA for e455e6c

• Unify pausing

  franzliedke

  committed
  e8394e4

  Copy full SHA for e8394e4

• Start decoupling scrolling from state

  franzliedke

  committed
  6f6a09d

  Copy full SHA for 6f6a09d

Commits on Aug 4, 2020

• Default parameter value

  

  franzliedke

  authored and

  askvortsov1

  committed
  d4abf58

  Copy full SHA for d4abf58