Code

Basic Extension Dependency Support#2188

Code

Merged

askvortsov1 merged 32 commits intomasterflarum/framework:masterfrom as/extension_dependenciesflarum/framework:as/extension_dependenciesCopy head branch name to clipboardOct 2, 2020

+279-13

Commits

Commits on Sep 30, 2020

• Add relevant exceptions for enabling/disabling

  askvortsov1

  committed
  c8cfdad

• Add helper method for getting flarum extension dependencies

  askvortsov1

  committed
  e50f22b

• Add extension dependency resolver (Kahn's algorithm), plus unit tests

  askvortsov1

  committed
  7937f82

• Enable extensions in proper order

  askvortsov1

  committed
  acc4f65

• Fix no default when getting extension dependencies

  askvortsov1

  committed
  ec3cd0c

• Apply fixes from StyleCI

  Show description for 0722382
  

  luceos

  authored and

  askvortsov1

  committed
  0722382

• Use require instead of dedicated field to get extension dependencies

  askvortsov1

  committed
  6c686bb

• Apply fixes from StyleCI

  Show description for 787515d
  

  luceos

  authored and

  askvortsov1

  committed
  787515d

• Fix fake extension to not fail tests and be compliant

  askvortsov1

  committed
  c374baf

• Remove unnecessary import

  askvortsov1

  committed
  30ee917

• Fix constructor, remove KnownError since we'll need a custom handler

  askvortsov1

  committed
  fec6ff3

• Add custom handlers for dependency exceptions

  askvortsov1

  committed
  54a35b4

• Standardize return format

  askvortsov1

  committed
  2e4ebef

• Add frontend error handler for admin dashboard

  askvortsov1

  committed
  d12fe5b

• Fix dependentExtensions saving the wrong thing

  askvortsov1

  committed
  6e4b867

• Update src/Extension/Exception/DependentExtensionsException.php

  Show description for 7b405f0
  

  askvortsov1

  and

  luceos

  committed
  7b405f0

• Update for new alerts signature

  askvortsov1

  committed
  39ca931

• Add more tests for dependency resolution

  askvortsov1

  committed
  7be3c1f

• Remove dependency resolution portion

  askvortsov1

  committed
  d32bafc

• Store a set of installed extension composer names instead of an associative array to their package.jsons to save memory

  askvortsov1

  committed
  8becd7c

• Improve explanation for installedSet, put its values as true, not null

  askvortsov1

  committed
  ebe0107

Commits on Oct 2, 2020

• Fix comments

  askvortsov1

  committed
  3fa2cdd

• Get rid of the $installedSet mess, use $extensions to check what is/isn't a flarum extension instead.

  askvortsov1

  committed
  e1d6378

• Go back to using $installedSet to store composer package names for installed extensions

  askvortsov1

  committed
  7acf52b

• Code cleanup

  Show description for 58477b5
  askvortsov1

  committed
  58477b5

• Rename extensionDependencies to extensionDependencyIds for clarity

  askvortsov1

  committed
  8923b0c

• Apply fixes from StyleCI

  Show description for 12e60d9
  

  luceos

  authored and

  StyleCIBot

  committed
  12e60d9

• Improve extension dependency error messages, even though they aren't shown to users

  askvortsov1

  committed
  4ba8aba

• Apply fixes from StyleCI

  Show description for 294a8bc
  

  luceos

  authored and

  StyleCIBot

  committed
  294a8bc

• Fix leftover extensionDependencies

  askvortsov1

  committed
  36f8fa0

• Add workaround to modal bug caused by bootstrap JS

  askvortsov1

  committed
  fef0d48

• Remove unnecessary changes

  askvortsov1

  committed
  d65b767