Fix opening modals from other modals. #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
franzliedke,
clarkwinkelmann,
dsevillamartin and
tankerkiller125
Merged
askvortsov1
added a commit
that referenced
this pull request
Aug 16, 2020
…ably be removed soon as per #2263
tankerkiller125
approved these changes
Aug 16, 2020
askvortsov1
force-pushed
the
mithril-2-modal-fix
branch
from
07a9099 to
ee7503b
Compare
65 tasks
franzliedke
force-pushed
the
mithril-2-update
branch
from
b59d383 to
6f4de6c
Compare
franzliedke
pushed a commit
that referenced
this pull request
Sep 18, 2020
…ably be removed soon as per #2263
franzliedke
force-pushed
the
mithril-2-update
branch
from
8c63ff2 to
161cd57
Compare
askvortsov1
force-pushed
the
mithril-2-modal-fix
branch
from
ee7503b to
93e477c
Compare
While seemingly correct, an onremove method in Modal that triggers animateHide is problematic, because if one modal is opened from another, the one currently open will be removed from the DOM, triggering animateHide, and closing the new modal. To compensate, an onupdate method now closes a modal if one is open but shouldn't be; this supports the functionality of the old method when the modal is closed not from the modal instance itself (e.g. app.modal.close()) This is not ideal, but necessary. We should consider eventually expanding the modal system to support showing multiple modals at the same time (stacked over each other). Then, we can move this back to individual modals.
askvortsov1
force-pushed
the
mithril-2-modal-fix
branch
from
93e477c to
7f3b2e9
Compare
askvortsov1
added a commit
that referenced
this pull request
Sep 25, 2020
This reverts commit 5b157f0.
Merged
askvortsov1
added a commit
that referenced
this pull request
Sep 25, 2020
This reverts commit 5b157f0.
askvortsov1
added a commit
that referenced
this pull request
Sep 29, 2020
This reverts commit 5b157f0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE WHEN APPROVED, REROUTE TO MASTER AFTER THE REWRITE IS MERGED
While seemingly correct, an onremove method in Modal that triggers animateHide is problematic, because if one modal is opened from another, the one currently open will be removed from the DOM, triggering animateHide, and closing the new modal.
To compensate, an onupdate method now closes a modal if one is open but shouldn't be; this supports the functionality of the old method when the modal is closed not from the modal instance itself (e.g. app.modal.close())
This is not ideal, but necessary. We should consider eventually expanding the modal system to support showing multiple modals at the same time (stacked over each other). Then, we can move this back to individual modals.