-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Config class #2271
New Config class #2271
Conversation
77f9420
to
6eca242
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like these changes a lot, much nicer now that we can inject the config. Left a few small comments here and there
6eca242
to
db05890
Compare
30473eb
to
121607a
Compare
121607a
to
9ea57e6
Compare
An unforeseen consequence of making the Maybe we should have different classes per environment, but that feels unnecessary as well. What do you think? |
Perhaps we should just make it not required again? Or pass in an array of "required keys" to the constructor (with the default being ['url'])? Either way, this is another reason why we need more robust e2e testing, so it's good to see us moving towards that. |
This extracts another real class for dealing with the configuration options stored in
config.php
.Similar to #2142, where I introduced a
Paths
class. The idea is to reduce the scope of theApplication
class and make it easier to inject exactly what's needed (rather than an array, which is complicated, or the bloatedApplication
class).