Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where posts API doesn't return the right amount of posts #2291

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Fix issue where posts API doesn't return the right amount of posts #2291

merged 1 commit into from
Sep 18, 2020

Conversation

w-4
Copy link
Contributor

@w-4 w-4 commented Sep 8, 2020

Fixes #2071

Changes proposed in this pull request:
Check for permissions when getting the post Ids.

  • Tested locally

askvortsov1
askvortsov1 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

dsevillamartin
dsevillamartin approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@dsevillamartin dsevillamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally and it works. Thank you so much! I think I'll want Franz or luceos to take a look before merging, but this LGTM.

@luceos
Copy link
Member

luceos commented Sep 13, 2020

We need to identify where we use this method and prevent the whereVisibleTo to be added after that.

@clarkwinkelmann
Copy link
Member

This sounds like a good fix.

We need to identify where we use this method

You mean getPostIds? That one is private and used only from there.

@askvortsov1 askvortsov1 merged commit 633cc14 into flarum:master Sep 18, 2020
This was referenced Oct 2, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@Pi-Bouf Pi-Bouf Pi-Bouf approved these changes

@dsevillamartin dsevillamartin dsevillamartin approved these changes

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@luceos luceos luceos approved these changes

@clarkwinkelmann clarkwinkelmann Awaiting requested review from clarkwinkelmann

@franzliedke franzliedke Awaiting requested review from franzliedke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guest users can't load more posts on profiles
7 participants
@w-4 @luceos @clarkwinkelmann @tankerkiller125 @dsevillamartin @Pi-Bouf @askvortsov1