Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various TypeScript improvements #2309

Merged
merged 11 commits into from
Oct 2, 2020
Merged

Various TypeScript improvements #2309

merged 11 commits into from
Oct 2, 2020

Conversation

askvortsov1
Copy link
Sponsor Member

See commit titles/descriptions

@askvortsov1 askvortsov1 mentioned this pull request Sep 24, 2020
Closed
65 tasks
dsevillamartin
dsevillamartin reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@dsevillamartin dsevillamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is public by default, I don't think there's any point in adding public everywhere - just protected or private (which won't convert into protected/private JS, it'll just warn).

js/src/common/Component.ts Outdated Show resolved Hide resolved
@askvortsov1
Copy link
Sponsor Member Author

Everything is public by default, I don't think there's any point in adding public everywhere - just protected or private (which won't convert into protected/private JS, it'll just warn).

I like having it there, if only to explicitly specify the difference when looking at code. Open to changing my mind on this one though

franzliedke
franzliedke suggested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like where this is going!

js/src/common/Component.ts Show resolved Hide resolved
js/src/common/components/Alert.tsx Show resolved Hide resolved
js/src/common/states/AlertManagerState.ts Outdated Show resolved Hide resolved
js/src/common/states/AlertManagerState.ts Outdated Show resolved Hide resolved
@franzliedke
Copy link
Contributor

I tend to agree with @datitisev about public. Typescript already adds a lot of boilerplate, so seeing something that's plain modern JS is a nice feeling. 😆

clarkwinkelmann
clarkwinkelmann reviewed Sep 27, 2020
View reviewed changes
js/shims.d.ts Outdated Show resolved Hide resolved
franzliedke
franzliedke suggested changes Sep 29, 2020
View reviewed changes
js/shims.d.ts Show resolved Hide resolved
js/src/common/components/Alert.tsx Show resolved Hide resolved
@askvortsov1 askvortsov1 merged commit d695d96 into master Oct 2, 2020
@askvortsov1 askvortsov1 deleted the as/alert-manager-state-ts branch October 2, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@dsevillamartin dsevillamartin dsevillamartin approved these changes

@tankerkiller125 tankerkiller125 Awaiting requested review from tankerkiller125

@franzliedke franzliedke Awaiting requested review from franzliedke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@askvortsov1 @franzliedke @clarkwinkelmann @dsevillamartin