Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passive Scroll Event Listener #2387

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Passive Scroll Event Listener #2387

merged 1 commit into from
Oct 15, 2020

Conversation

w-4
Copy link
Contributor

@w-4 w-4 commented Oct 13, 2020

see: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

A Boolean that, if true, indicates that the function specified by listener will never call preventDefault(). If a passive listener does call preventDefault(), the user agent will do nothing other than generate a console warning. See Improving scrolling performance with passive listeners to learn more.

The ScrollListener util is used in PostStream and PostStreamScrubber.

Confirmed

  • Frontend changes: tested on a local Flarum installation.

askvortsov1
askvortsov1 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@askvortsov1 askvortsov1 merged commit 20b9455 into flarum:master Oct 15, 2020
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsevillamartin dsevillamartin dsevillamartin approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@clarkwinkelmann clarkwinkelmann Awaiting requested review from clarkwinkelmann

@luceos luceos Awaiting requested review from luceos

@tankerkiller125 tankerkiller125 Awaiting requested review from tankerkiller125

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0-beta.14
Development

Successfully merging this pull request may close these issues.
3 participants
@w-4 @dsevillamartin @askvortsov1