Add Notification Type Extender #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested changes
Oct 29, 2020
askvortsov1
requested changes
Oct 31, 2020
SychO9
commented
Oct 31, 2020
This was referenced Oct 31, 2020
askvortsov1
approved these changes
Oct 31, 2020
askvortsov1
requested review from
clarkwinkelmann,
luceos and
tankerkiller125
tankerkiller125
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2422
Part of #1891
Reviewers should focus on:
Would it be better to try avoiding duplicating this block of code (by defining a singleton and extending that instead in the extender)
https://github.com/flarum/core/blob/24b7a21507c4bdc5f44d1fed633129915ade0bd7/src/Notification/NotificationServiceProvider.php#L42-L59
Confirmed
[ ] Frontend changes: tested on a local Flarum installation.composer test).