Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Beta14 Code #2428

Merged
merged 7 commits into from
Dec 1, 2020
Merged

Conversation

askvortsov1
Copy link
Member

@askvortsov1 askvortsov1 commented Oct 30, 2020

Fixes #2346
Fixes #2278

Changes proposed in this pull request:

  • Remove momentjs alias
  • Remove various beta 14 frontend BC layers
  • Remove deprecated User events
  • Remove path helpers and Application methods
  • Remove AssertPermissionTrait

Reviewers should focus on:
I left in the warnings and errors for invalid attrs in Component and in the various Modal / Alert / etc, because those can be common mistakes. I'd definitely like to keep the Component ones, not 100% sure about modal, alert, and composer.
Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good code-wise.

Yes I think it's good to keep some of the warnings for easy errors that aren't specific to the beta 14 update. The children warning could probably be removed IMO since that construct will not be found in any example in either Flarum or Mithril anymore. Warnings for parameter orders still make sense, so do the checks for parameters to modals and alerts.

I would still suggest we keep this on hold for a bit (1 or 2 more weeks) until more extensions finished migrating to beta 14. We might still find some surprises related to what we have here, and I'd prefer we not need to revert some of the stuff later on.

@askvortsov1
Copy link
Member Author

There isn't really anything in the release that this is blocking, so we could just wait to merge it until feature freeze. Only matter is to decide which warnings to keep and which to remove. My thoughts about children are since its one of the most common changes needed, but the initial error message isn't super clear, so if some extensions are migrating late during next release cycle, it might help them. And then all this could be removed before stable.

@clarkwinkelmann
Copy link
Member

My thoughts about children are since its one of the most common changes needed, but the initial error message isn't super clear

True, some of those warnings are super helpful when compared to what error message would appear without them. It's worth keeping them for developer sanity even if they rarely happen 😇

@askvortsov1 askvortsov1 merged commit fe41bc1 into master Dec 1, 2020
@askvortsov1 askvortsov1 deleted the as/remove-deprecated-beta-15 branch December 1, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove B14 BC layers Remove deprecated "moment" dayjs alias for Beta 15.
3 participants