-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecated Beta14 Code #2428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good code-wise.
Yes I think it's good to keep some of the warnings for easy errors that aren't specific to the beta 14 update. The children
warning could probably be removed IMO since that construct will not be found in any example in either Flarum or Mithril anymore. Warnings for parameter orders still make sense, so do the checks for parameters to modals and alerts.
I would still suggest we keep this on hold for a bit (1 or 2 more weeks) until more extensions finished migrating to beta 14. We might still find some surprises related to what we have here, and I'd prefer we not need to revert some of the stuff later on.
There isn't really anything in the release that this is blocking, so we could just wait to merge it until feature freeze. Only matter is to decide which warnings to keep and which to remove. My thoughts about |
True, some of those warnings are super helpful when compared to what error message would appear without them. It's worth keeping them for developer sanity even if they rarely happen 😇 |
Fixes #2346
Fixes #2278
Changes proposed in this pull request:
Reviewers should focus on:
I left in the warnings and errors for invalid attrs in Component and in the various Modal / Alert / etc, because those can be common mistakes. I'd definitely like to keep the Component ones, not 100% sure about modal, alert, and composer.
Confirmed
composer test
).