Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Permissions Error Messages for Initial Install #2435

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Improved Permissions Error Messages for Initial Install #2435

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f9f0d3
Improved Permissions Error Messages for Initial Install
nina-py Nov 3, 2020
cc17df1
Updated wording of the error message
nina-py Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Install/Prerequisite/WritablePaths.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ private function getNonWritablePaths(): Collection
})->map(function ($path, $index) {
return [
'message' => 'The '.$this->getAbsolutePath($path).' directory is not writable.',
'detail' => 'Please chmod this directory'.(in_array($index, $this->wildcards) ? ' and its contents' : '').' to 0775.'
'detail' => 'Please make sure your web server/PHP user has write access to this directory'.(in_array($index, $this->wildcards) ? ' and its contents' : '').'. Please read the <a href="https://docs.flarum.org/install.html#folder-ownership">installation documentation</a> for a detailed explanation and steps to follow to resolve this error.'
Copy link
Sponsor Member

@askvortsov1 askvortsov1 Nov 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording critiques:

  • Both sentences start with please, that's a bit much imo, we can probably remove that from the second sentence.
  • "steps to follow to resolve this error" => "steps to resolve this error"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with both changes - looks better now.

];
});
}
Expand Down