WIP: Split Search Filter and Search #2453
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of flarum/issue-archive#286
Changes proposed in this pull request:
TODO:
Reviewers should focus on:
What if we used one endpoint, and searched vs filtered based on the presence of the
q
parameter? And what if SimpleFlarumSearch internally used filtration as its gambits (and all gambits were applied as key-values on thefilter
param instead of as part of theq
string?