Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1306
Changes proposed in this pull request:
Abstracted common functionality into a generic UploadImageController class. Did not tackle SVG support as it's not defined in the issue what this should be - simply leave them as is as for
.ico
files? Or something else? Happy to tackle this either in this PR or separately.Reviewers should focus on:
The refactored code; new class property names in particular in UploadImageController.
Confirmed
composer test
).Required changes: