-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 support #2507
PHP 8 support #2507
Conversation
|
@franzliedke thank you, I was hoping for that 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the main showstopper was the cookie library originally, this looks good I see no issues with the cookie lib replacement and CI test are passing. (I have no tested locally yet)
caret already allows for higher versions
[ci skip] [skip ci]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like our current library was updated: https://packagist.org/packages/dflydev/fig-cookies
In the spirit of minimal changes, I'd say we should stick with that, although keep the new tests (and include a test case for calling ->expires())
Sorry for all the back and forth on this one
fixes #2439
Attempts to offer support for php 8, so far: