Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flarum/testing for test infrastructure #2545

Merged
merged 6 commits into from
Mar 7, 2021
Merged

Conversation

askvortsov1
Copy link
Member

@askvortsov1 askvortsov1 commented Jan 13, 2021

**Ref #2543 **

Changes proposed in this pull request:
Delete old testing infrastructure in favor of that in flarum/testing

Confirmed

  • [ ] Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@clarkwinkelmann
Copy link
Member

clarkwinkelmann commented Mar 7, 2021

Globally this seems all right.

I'm just curious where the temporary directory went? I see there are some system variables for it in flarum/testing. Is there a gitignore for the default location if those system variables aren't set? Is that tmp folder created inside of vendor/flarum/testing by default? (__DIR__ . '/tmp https://github.com/flarum/testing/blob/main/src/integration/UsesTmpDir.php) That doesn't seem right

@askvortsov1
Copy link
Member Author

Is that tmp folder created inside of vendor/flarum/testing

It is. There's some discussion on this in #2544.

Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I didn't see that discussion. Looks fine then, let's go ahead with this.

@askvortsov1 askvortsov1 merged commit 2c3e1f9 into master Mar 7, 2021
@askvortsov1 askvortsov1 deleted the as/move-tests-out branch March 7, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants