added powered-by-header

[luceos]

Adds a X-Powered-By header. It can be disabled using:

Flarum\Http\Middleware\FlarumPromotionHeader::disable() in extend.php.

[KyrneDev]

Something I didn't know we needed but I love it! Everything works locally from testing.

[askvortsov1]

It can be disabled using:

Flarum\Http\Middleware\FlarumPromotionHeader::disable() in extend.php.

The Compat extender is going away with stable, so no more callbacks in extend.php. I suppose it could also be done outside a callback, but I would prefer for extend.php to remain just extenders. Instead, let's use the config.php.

[luceos]

I've refactored based on the review. You can now disable the promotion header in the config.php like so:

<?php

return [
    'url' => 'http://toby.local',
    'debug' => true,
    'promote' => false,
    // ..
];

If the promote value is true, null or is not available from the config it will assume true.

[askvortsov1]

Suggested change

	$this->enabled = $config['promote'] ?? true;
	$this->enabled = $config['flarumPromotionalHeader'] ?? true;

[tankerkiller125]

I feel like that suggested name is a little long? I'm perfectly fine with simple "promote" if we did want to explain it more maybe "promotionHeader" or "poweredByHeader"

[askvortsov1]

I like it!

[SychO9]

can we also add the key to StoreConfig.php so that it's there by default ?

[askvortsov1]

can we also add the key to StoreConfig.php so that it's there by default ?

Good point. It'll also be in the release announcement and config.php docs

[askvortsov1]

I think "promote" is too broad, "promoteFlarumHeader" or "promoteFlarum" might be better.

[KyrneDev]

I think "promote" is too broad, "promoteFlarumHeader" or "promoteFlarum" might be better.

What about "promoHeader"