Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Part of flarum/issue-archive#286 **
Changes proposed in this pull request:
Move search results, search criteria, and ApplySearchParametersTrait to Query namespace.
They still extend (empty) search equivalents as a BC layer for extensions that expect those types.
Reviewers should focus on:
A few changes I'm considering, but am unsure about:
query
method, and having both searchers and filterers implement it instead offilter
andsearch
methods. Leaning against this though because it isn't really necessary, and I don't see the benefits.An actual extender for search drivers will have to wait until next release (or later), although that shouldn't be too difficult. Not a priority right now though.