Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear cache files from storage/views #2648

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

emamulkhan
Copy link
Contributor

Fixes #0000
2630 - #2630

Changes proposed in this pull request:

src/Extend/View.php
added OnEnable and OnDisable methods - to clear cache files from storage/views folder when an extension is enabled or disabled from admin

src/Foundation/Console/CacheClearCommand.php
added a line of code to remove cache files from storage/views folder

Reviewers should focus on:
Testing if the cache files are removed from storage/views when cache clear command is executed and when an extension is enabled/disabled

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@emamulkhan
Copy link
Contributor Author

emamulkhan commented Mar 1, 2021

@askvortsov1 - created the PR again,i hope this should be fine

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code works. Thanks again!

@KyrneDev KyrneDev merged commit 7fa22a1 into flarum:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants