Removes duplication of cache clearing #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Makes sense to me! I would eventually like to see caches move to a unified system ala https://github.com/flarum/core/issues/2727#issuecomment-805774878, but that's a matter for another release.
SychO9
requested changes
Mar 25, 2021
SychO9
approved these changes
Mar 26, 2021
askvortsov1
approved these changes
Mar 26, 2021
|
2 approvals. Anything I'm missing or is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR removes the duplicated cache clearing of the locales. The locales are cleared using the cache:clear command which is centrally dispatched from the CacheClear command. Using an listener on the ClearingCache event causes extensions to fail to do stuff with locales.
Eg:
Ref: https://github.com/flarum/core/blob/d642fb531c1335c33ff7515da367f6815ea93b12/src/Foundation/Console/CacheClearCommand.php#L69
Confirmed
Frontend changes: tested on a local Flarum installation.composer test).