-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix registering custom searchers, allow searchers without fulltext #2755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there doesn't exist a fulltext gambit for a model, then it's not really "searchable", and as such, a filterer should be used.
I agree, extension developers might try to use gambits when what they really need is filters instead. Throwing an exception somewhere -if we can- that makes it clear would be great as well.
This reverts commit 819fef1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested locally, but this looks good to me.
I was worried that gambits might be resolved too early, but that doesn't seem to be an issue. The array is resolved in boot
, but the actual classes are only container->make()
inside of the container binding so it's fine.
My only issue is the comment below.
6c989ae
to
dc07338
Compare
3de8fc9
to
b10af17
Compare
[ci skip] [skip ci]
Reverted the exception as I was unable to catch it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a similar problem with trying to catch an exception from tests, it just wasn't possible.
Fixes #2712
Changes proposed in this pull request:
Confirmed
composer test
).