Adds missing settings defaults for display name driver and User slug driver #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
force-pushed
the
dw/add-missing-settings-defaults
branch
from
0337ffe
to
3561f90
Compare
|
Rebased |
davwheat
force-pushed
the
dw/add-missing-settings-defaults
branch
from
3561f90
to
da442f1
Compare
SychO9
approved these changes
Jul 30, 2021
askvortsov1
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Adds missing default setting values for Display Name Driver and User Slug Driver. This will prevent empty select boxes for these settings on new Flarum installs.
Reviewers should focus on:
Should we add a migration to input these defaults on existing forums where they haven't already been set?
Confirmed
composer test).