feat: Allow registering settings as Less config vars through Settings Extender
#3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
reviewed
Aug 11, 2021
askvortsov1
reviewed
Aug 20, 2021
askvortsov1
approved these changes
Aug 21, 2021
davwheat
approved these changes
Aug 22, 2021
…/core into sm/2819-less-config-vars-settings
askvortsov1
requested changes
Aug 27, 2021
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
[ci skip] [skip ci]
askvortsov1
approved these changes
Aug 27, 2021
davwheat
approved these changes
Sep 20, 2021
8 tasks
# Conflicts: # src/Extend/Settings.php # src/Frontend/FrontendServiceProvider.php # tests/integration/extenders/SettingsTest.php
SychO9
commented
Nov 1, 2021
askvortsov1
approved these changes
Nov 1, 2021
SychO9
changed the title
LESS config vars through Settings ExtenderLess config vars through Settings Extender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2819
Changes proposed in this pull request:
This PR adds a
registerLessConfigVarmethod to the settings extender that allows passing those settings values to theLESScode similarly to how they are serialized to the frontend. It also makes sure such settings always flushes the CSS cache when saving new values.In the issue linked, the plan was to initially introduce this in a
Themeextender so that, but theSettingsextender make more sense, since all we want is to directly use settings as config vars.Reviewers should focus on:
General code quality, anything I might've missed.
Confirmed
composer test).