Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace for ... in with Array.reduce #3149

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Nov 3, 2021

Changes proposed in this pull request:

Replace for ... in loop with Array.reduce.

Reviewers should focus on:

It's a reduction in bundle size (one whole byte!!), and I think it benefits from the readability and helps to set our precedent for more modern helper methods within Flarum.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now do it in OCaml

@davwheat
Copy link
Member Author

davwheat commented Nov 3, 2021

@askvortsov1 yeah think I'll pass on that one... 😂

@davwheat davwheat merged commit 6eb05cf into master Nov 3, 2021
@davwheat davwheat deleted the dw/modern-array-methods branch November 3, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants