Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Close' & 'Back' aria-label attributes to buttons. #3161

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Add 'Close' & 'Back' aria-label attributes to buttons. #3161

merged 6 commits into from
Nov 11, 2021

Conversation

grimmdude
Copy link
Contributor

@grimmdude grimmdude commented Nov 11, 2021 •
edited by SychO9
Loading

Changes proposed in this pull request:
Adds aria-label attribute to modal close & back buttons to improve accessibility and satisfy these warnings.

Screen Shot 2021-11-11 at 10 08 32 AM

Reviewers should focus on:
Affects every modal and the hero welcome component.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@grimmdude grimmdude changed the title Add 'Close' aria-label attributes to close buttons. Add 'Close' & 'Back' aria-label attributes to buttons. Nov 11, 2021
davwheat
davwheat reviewed Nov 11, 2021
View reviewed changes
js/src/forum/components/WelcomeHero.js Outdated Show resolved Hide resolved
locale/core.yml Outdated Show resolved Hide resolved
SychO9
SychO9 reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

js/src/common/components/Navigation.js Outdated Show resolved Hide resolved
SychO9
SychO9 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@askvortsov1 askvortsov1 added this to the 1.2 milestone Nov 11, 2021
askvortsov1
askvortsov1 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SychO9 SychO9 added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Nov 11, 2021
@SychO9 SychO9 linked an issue Nov 11, 2021 that may be closed by this pull request
[A11Y] Modal close buttons have no accessible label #2975
Closed
@SychO9 SychO9 removed this from the 1.2 milestone Nov 11, 2021
@askvortsov1 askvortsov1 merged commit 9b9ca53 into flarum:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@SychO9 SychO9 SychO9 approved these changes

@davwheat davwheat Awaiting requested review from davwheat

Assignees
No one assigned
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11Y] Modal close buttons have no accessible label
4 participants
@grimmdude @davwheat @SychO9 @askvortsov1