Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @php in Blade templates #3172

Merged
merged 3 commits into from
Nov 23, 2021
Merged

chore: use @php in Blade templates #3172

merged 3 commits into from
Nov 23, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Nov 20, 2021

Changes proposed in this pull request:

As per title.

Reviewers should focus on:

None

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Nov 20, 2021
@askvortsov1
Copy link
Sponsor Member

askvortsov1 commented Nov 20, 2021

Eh, not sure I agree with this. If we're taking action here, we might as well fix the issue: it shouldn't be too challenging.

@davwheat
Copy link
Member Author

I think "issue" is stretching it. As far as I can see, @php is just alternate syntax to <?php, isn't it?

@davwheat davwheat changed the title chore: remove comment chore: use @php in Blade templates Nov 20, 2021
@davwheat davwheat merged commit 86d23a5 into master Nov 23, 2021
@davwheat davwheat deleted the dw/remove-comment branch November 23, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants