Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modal rewrite to use native HTML Dialog element + polyfill #3246

Closed
wants to merge 4 commits into from

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jan 1, 2022

Fixes flarum/issue-archive#124

Changes proposed in this pull request:

Replaces Bootstrap modals with HTML5 Dialog element and polyfill.

This reduces our bundle, and improves accessibility.

Reviewers should focus on:

Testing extension modal implementations work with these changes.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added type/cleanup type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) labels Jan 1, 2022
@davwheat davwheat self-assigned this Jan 1, 2022
@davwheat davwheat marked this pull request as draft January 1, 2022 15:58
@davwheat
Copy link
Member Author

davwheat commented Jan 1, 2022

Why is this increasing our bundle 🙈

@davwheat davwheat requested a review from luceos January 31, 2022 09:38
@askvortsov1
Copy link
Member

Hello, thank you for your pull request! In order to speed up future development, keep all work in one place, and take advantage of CI tools that can help us avoid breaking changes, we have moved all Flarum code to a single monorepo at flarum/framework. You can read more about this process in our dev diary. Unfortunately, pull requests can't be carried over to the monorepo, so we have to close all open pull requests. If this pull request is still relevant, please feel free to reopen it over on the monorepo. We apologize for the inconvenience, and hope you will consider contributing to Flarum again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) type/cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modals close when mouseup event triggered outside modal bounds
2 participants