Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification timestamp mismatched from other core code #3379

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Apr 5, 2022

Changes proposed in this pull request:

When running Flarum with a customised config on a server which uses a non-UTC timezone, there is a mismatch with notifications since these are handled as UTC, while other timestamps are handled in local time. This PR changes notifications to use local time, like everything else in core.

Reviewers should focus on:

Does this present an issue for existing communities? I argue not, as noone else has noticed this until now, so a fix would have just as small of an effect as the current issue has.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Apr 5, 2022
@davwheat davwheat merged commit 9f7c5de into main Apr 5, 2022
@davwheat davwheat deleted the dw/carbon-utc branch April 5, 2022 14:38
@BartVB
Copy link

BartVB commented Apr 5, 2022

That was quick :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants