fix: notification timestamp mismatched from other core code #3379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
When running Flarum with a customised config on a server which uses a non-UTC timezone, there is a mismatch with notifications since these are handled as UTC, while other timestamps are handled in local time. This PR changes notifications to use local time, like everything else in core.
Reviewers should focus on:
Does this present an issue for existing communities? I argue not, as noone else has noticed this until now, so a fix would have just as small of an effect as the current issue has.
Necessity
Confirmed
composer test
).