Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Tag selection modal input visibility #3412

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 6, 2022

Fixes #0000

Changes proposed in this pull request:
The tag selection modal input contains misaligned selected tags and the cursor is not visible on the input. There is also no focus ring indicating that it is an input.

Screenshot

Before After
Screenshot from 2022-05-06 11-33-55 Screenshot from 2022-05-06 11-55-28

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added type/bug type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) labels May 6, 2022
@SychO9 SychO9 requested review from dsevillamartin and davwheat May 6, 2022 10:59
@luceos luceos merged commit da83e0c into main May 9, 2022
@luceos luceos deleted the sm/tagsmodal-input branch May 9, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants