fix: restricted sibling tags appearing for unauthorized members on the sidebar #3419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Loading the
parent.children
tag relation grabs the models without checking for permissions.This PR makes sure that the relation is passed through a permission check first (repository class code) and then if a
parent.children.parent
relation is also included, it manually attached that relation instead of trying to eager load it.parent.children
to relation permission check array.parent.children.parent
relation is passed in the controller.parent
tochildren
.parent.children.parent
.Necessity
Confirmed
composer test
).