Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add priorities to UserCard component #3436

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

imorland
Copy link
Member

Changes proposed in this pull request:
Add priorities to UserCard itemList. This will allow extensions to specify easily where any additional items should be placed :)

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested review from davwheat and SychO9 May 20, 2022 19:24
@imorland imorland added this to the 1.4 milestone May 20, 2022
@imorland imorland merged commit 96ead2a into main May 20, 2022
@imorland imorland deleted the imorland-patch-1 branch May 20, 2022 19:32
@SychO9 SychO9 changed the title Add priorities to UserCard chore: add priorities to UserCard component May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants