fix(ext typings): remove some accessibility modifiers from Component #3437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
At the moment, our
Component
class has various protected attributes and methods. Sometimes, we need to override/extend these methods (initAttrs
) or to use these attributes (this.$
/this.attrs
) within the body ofextend
oroverride
.This presents an issue, as our typings pretend these don't exist outside of the class and its subclasses, so show up as errors in TS.
This PR removes those accessibility modifiers to prevent these TS errors.
Reviewers should focus on:
I don't see this as an issue since these are regularly used outside of the classes anyway in JS-based extends/overrides.
Necessity
Confirmed
composer test
).