Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y: DiscussionListItem): controls dropdown not visible when tabbed into #3450

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(a11y: DiscussionListItem): controls dropdown not visible when tabbed into #3450

merged 1 commit into from
Jun 20, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jun 3, 2022

Changes proposed in this pull request:

When tabbing through DiscussionListItems, the controls dropdown gains focus but remains hidden with opacity: 0. This PR sets opacity: 1 when focus is within the controls DOM to make this visible again.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Jun 3, 2022
@davwheat davwheat added this to the 1.4 milestone Jun 3, 2022
@davwheat davwheat self-assigned this Jun 3, 2022
@SychO9 SychO9 modified the milestones: 1.3.1, 1.4 Jun 7, 2022
@davwheat davwheat merged commit 36c296d into main Jun 20, 2022
@davwheat davwheat deleted the dw/dli-dropdown-visibility branch June 20, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@askvortsov1 askvortsov1 Awaiting requested review from askvortsov1

Assignees

@davwheat davwheat

Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@davwheat @SychO9