Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace .fa() mixin usage with .fas() #3537

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

These mixin calls should be .fas() for solid icons rather than a standard .fa().

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.5 milestone Jul 15, 2022
@davwheat davwheat requested a review from SychO9 July 15, 2022 19:57
@davwheat davwheat self-assigned this Jul 15, 2022
@davwheat davwheat marked this pull request as ready for review July 15, 2022 19:57
@davwheat davwheat merged commit 5721a2f into main Jul 15, 2022
@davwheat davwheat deleted the dw/fix-fa-mixin-use branch July 15, 2022 22:16
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants