Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move guzzle requirement to core #3544

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix: Move guzzle requirement to core #3544

merged 1 commit into from
Jul 18, 2022

Conversation

imorland
Copy link
Member

@imorland imorland commented Jul 18, 2022

I just had an issue which caused 500 errors when sending mail, only using the mailgun driver. Turns out, we've always had a dependency on GuzzleHttp\Client, but not required it in composer.json

Changes proposed in this pull request:
Remove GuzzleHttp/Guzzle from flarum/askimet, and onto core itself.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland added this to the 1.5 milestone Jul 18, 2022
@davwheat davwheat self-assigned this Jul 18, 2022
@davwheat davwheat merged commit 8dcfa6c into main Jul 18, 2022
@davwheat davwheat deleted the im/guzzle branch July 18, 2022 15:10
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants