Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert tsconfig changes for local development #3545

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 18, 2022

Changes proposed in this pull request:
Changes here 4e52f0e have yielded unwanted effects in that dist typings also complied core and extension sources in other extensions.

Attempted to fix that through changing action build to allow deleting unwanted files, but got even more problems, so reverting fo now.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 2 commits July 18, 2022 22:22
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 merged commit 64f0ae7 into main Jul 19, 2022
@SychO9 SychO9 deleted the sm/revert-tsconfig-localdev branch July 19, 2022 09:30
@SychO9 SychO9 changed the title Revert tsconfig changes for local development chore: revert tsconfig changes for local development Jul 19, 2022
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants