Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restart the queue worker after cache clearing, ext enable/disable, save settings #3565

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

imorland
Copy link
Member

**Fixes #3563 **

Changes proposed in this pull request:
Adds a subscriber to trigger the queue to restart after certain events

Reviewers should focus on:
Tested locally with a standard redis based queue. Doesn't work with blomstra/horizon, although I think there's a seperate issue with that extension, which I'll start to investigate now

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@imorland imorland requested review from luceos and SychO9 July 26, 2022 13:45
imorland and others added 2 commits July 26, 2022 16:17
@imorland imorland added this to the 1.5 milestone Jul 27, 2022
@imorland imorland self-assigned this Jul 28, 2022
@luceos luceos merged commit da855c6 into main Aug 1, 2022
@luceos luceos deleted the im/queue-restarter branch August 1, 2022 22:49
@SychO9 SychO9 removed this from the 1.5 milestone Aug 2, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart the queue on cache clear, extension enable/disable and extension settings save
4 participants