Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect centring of deleted user avatars in notification list #3569

Merged
merged 2 commits into from
Jul 28, 2022
Merged

fix: incorrect centring of deleted user avatars in notification list #3569

merged 2 commits into from
Jul 28, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jul 28, 2022 •
edited
Loading

Changes proposed in this pull request:

  • fix vertical alignment of user avatars in the notification list when a user has been deleted

Screenshot

image

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.5 milestone Jul 28, 2022
@davwheat davwheat requested a review from SychO9 July 28, 2022 15:28
@davwheat davwheat self-assigned this Jul 28, 2022
@davwheat davwheat marked this pull request as ready for review July 28, 2022 15:29
@davwheat davwheat merged commit 7d67cfd into main Jul 28, 2022
@davwheat davwheat deleted the dw/deleted-avatar-notifs branch July 28, 2022 16:15
@luceos luceos mentioned this pull request Jul 30, 2022
Closed
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@imorland imorland imorland approved these changes

Assignees

@davwheat davwheat

Labels
type/bug
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@davwheat @imorland @SychO9